[PATCH] D53801: [libc++abi] Provide __cxa_thread_atexit on Fuchsia
Petr Hosek via Phabricator
reviews at reviews.llvm.org
Sun Oct 28 16:36:05 PDT 2018
phosek added a comment.
In https://reviews.llvm.org/D53801#1278430, @mcgrathr wrote:
> I don't know what's affected by the presence of that declaration. Certainly it should be defined.
> AFAICT this has nothing to do with solving the problem of the symbol not existing in the library.
> That needs CMakeLists.txt:34 changed so it compiles cxa_thread_atexit.cpp for Fuchsia.
I missed that one.
> We also need to make sure that the cmake check for presence of __cxa_thread_atexit_impl in libc is passing correctly.
I already checked that one and it's being detected properly.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D53801
More information about the libcxx-commits
mailing list