[PATCH] D52405: [libc++] Use exclude_from_explicit_instantiation instead of always_inline
Eric Fiselier via Phabricator
reviews at reviews.llvm.org
Fri Oct 26 14:19:09 PDT 2018
EricWF added a comment.
LGTM other than the inline comments.
The chrome binary size goes from `810 MB` to `756 MB` after this patch.
================
Comment at: libcxx/include/__config:802
+#if __has_attribute(exclude_from_explicit_instantiation)
+# define _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION __attribute__ ((exclude_from_explicit_instantiation))
+#else
----------------
We should use the reserved spelling `__exclude_from_explicit_instantiation__`.
Repository:
rCXX libc++
https://reviews.llvm.org/D52405
More information about the libcxx-commits
mailing list