[PATCH] D53670: Revert "Teach __libcpp_is_floating_point that __fp16 and _Float16 are"

Wed Oct 24 15:47:18 PDT 2018

ldionne added a comment.

In https://reviews.llvm.org/D53670#1275107, @EricWF wrote:

> Sorry I'm late to the party, but we should just be falling back to `__is_floating_point` if we have it. Since it will always give us the answer we want. (Including for `__float128` which we don't handle ATM).

That doesn't change the fact that it would be lying about what it means to be a floating point type, wouldn't it? For example, `numeric_limits` would still not be defined for `__fp16`, right?

As a side question, do you know how `numeric_limits` are implemented for `__float128`?

Repository:
  rL LLVM

https://reviews.llvm.org/D53670