[PATCH] D53631: Fix libcxx build with MinGW winpthreads

Marshall Clow via Phabricator reviews at reviews.llvm.org
Wed Oct 24 09:14:52 PDT 2018


mclow.lists added inline comments.


================
Comment at: include/__config:1228
 
-#if __has_attribute(require_constant_initialization)
+#if __has_attribute(require_constant_initialization) &&                        \
+    !(defined(_LIBCPP_HAS_THREAD_API_PTHREAD) && defined(__MINGW32__))
----------------
I think you want to look at line #1155, and see if `_LIBCPP_HAS_THREAD_API_WIN32` is the condition you want here.



Repository:
  rCXX libc++

https://reviews.llvm.org/D53631





More information about the libcxx-commits mailing list