[PATCH] D53486: [libcxx] Only define __libcpp_is_floating_point<_Float16> for Clang

Marshall Clow via Phabricator reviews at reviews.llvm.org
Tue Oct 23 16:33:36 PDT 2018


mclow.lists added a comment.

In https://reviews.llvm.org/D53486#1273206, @phosek wrote:

> A possible reason to go with the current option is `__libcpp_is_floating_point<_Float16>` that has been in libc++ for a few months and has been shipped with 7.0, so there might already be users depending on this trait. Is that a concern? If yes, then current version is probably the right way to go.


This was added in r333103 by someone at Apple, but Apple has not shipped a set of headers that include this yet (unless they have done so for Mac OS 10.14 - which shipped in the last few weeks), so I would say that the set of people using this is very small.


Repository:
  rCXX libc++

https://reviews.llvm.org/D53486





More information about the libcxx-commits mailing list