[PATCH] D53486: [libcxx] Only define __libcpp_is_floating_point<_Float16> for Clang

Louis Dionne via Phabricator reviews at reviews.llvm.org
Tue Oct 23 07:06:02 PDT 2018


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Thinking about this more, I'm fine with either this patch or one that does not define `__libcpp_is_floating_point<_Float16>` at all. This patch provides the best level of support that we seem to be able to provide, but is inconsistent across compilers and does not follow the standard perfectly. Not providing the definition at all decreases the level of support but increases consistency and simplicity. I'm fine with either.


Repository:
  rCXX libc++

https://reviews.llvm.org/D53486





More information about the libcxx-commits mailing list