[PATCH] D52995: [CMake] Fix the -nodefaultlibs check.
Reid Kleckner via Phabricator
reviews at reviews.llvm.org
Thu Oct 18 21:31:55 PDT 2018
rnk added inline comments.
================
Comment at: cmake/config-ix.cmake:43
# configuration checks to avoid spurious link errors.
-check_c_compiler_flag(-nodefaultlibs LIBUNWIND_HAS_NODEFAULTLIBS_FLAG)
+check_linker_flag(-nodefaultlibs LIBUNWIND_HAS_NODEFAULTLIBS_FLAG)
if (LIBUNWIND_HAS_NODEFAULTLIBS_FLAG)
----------------
Do we really need a dynamic configure check here? Where is nodefaultlibs unsupported, just MSVC? If so, I'd rather drop the feature check and just say `if (NOT MSVC)`. Does libunwind even build with MSVC?
Repository:
rUNW libunwind
https://reviews.llvm.org/D52995
More information about the libcxx-commits
mailing list