[PATCH] D52662: [libc++] Make sure we can build libc++ with -fvisibility=hidden

[Louis Dionne via Phabricator]

ldionne added inline comments.


================
Comment at: libcxx/include/thread:170
 
+extern template _LIBCPP_EXPORTED_FROM_ABI void __thread_specific_ptr<__thread_struct>::__at_thread_exit(void*);
+
----------------
EricWF wrote:
> So we likely only got this symbol in the dylib as a result of an implicit instantiation. Changing this to an explicit instantiation might be ABI breaking.
We agreed we could just remove the symbol. I removed the instantiation, marked the function as hidden and documented that in the ABI list CHANGELOG.


================
Comment at: libcxx/src/iostream.cpp:80
 
-ios_base::Init __start_std_streams;
+_LIBCPP_EXPORTED_FROM_ABI ios_base::Init __start_std_streams;
 
----------------
EricWF wrote:
> Does this actually need to be exported to serve it's function of initializing the streams?
I don't think so -- I marked it as hidden.


Repository:
  rCXX libc++

https://reviews.llvm.org/D52662