[PATCH] D53127: Fix declaration of _URC_FATAL_PHASE1_ERROR in libc++abi when compiled with libsupc++ (follow-up of D42242)

Steffen Kuhn via Phabricator reviews at reviews.llvm.org
Sun Oct 14 10:48:17 PDT 2018


stefson added a comment.

Thanks for your input. Regarding the title, I've been critisized for suggesting that this issue is not about gcc misscompiling libc++abi, but for using gcc's ARM unwind abi. It's that I just now got my head around this, and I'm going to change it to reflect that. To answer the question: yes, I think this is about building against libgcc's arm unwind implemention and its lack of a few defines.

This patch is the missing part from the aforementioned fedora patch, the main part has been merged in https://reviews.llvm.org/D42242.

Now, it's been a bit naive of me to assume you'd accept it without requesting changes, as the patch makes things work for arm but may not be upstreamable, or not that easily.


Repository:
  rCXXA libc++abi

https://reviews.llvm.org/D53127





More information about the libcxx-commits mailing list