[PATCH] D53127: Fix declaration of _URC_FATAL_PHASE1_ERROR in libc++abi when compiled with libsupc++ (follow-up of D42242)
Saleem Abdulrasool via Phabricator
reviews at reviews.llvm.org
Sun Oct 14 10:28:14 PDT 2018
compnerd added a comment.
I'm not sure I understand this patch. Building libc++abi with libsupc++ doesn't make sense. They are both providing the same API. Are you trying to build against libgcc? The GNU Savannah libunwind as well as the LLVM libunwind provide the definitions AFAICT. libgcc has the definition in `unwind-common.h`.
================
Comment at: src/cxa_personality.cpp:1112
bool is_force_unwinding = state & _US_FORCE_UNWIND;
- state &= ~_US_FORCE_UNWIND;
+ state = (_Unwind_State)(state & ~_US_FORCE_UNWIND);
----------------
Unnecessary change?
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D53127
More information about the libcxx-commits
mailing list