[PATCH] D53215: [libcxx] Improve reporting when running the lit test suite

[Eric Fiselier via Phabricator]

EricWF added a comment.

Could you elaborate as to why this is needed/beneficial? Most of the information this patch adds to reports is already displayed to the user during the initial configuration.



================
Comment at: libcxx/utils/libcxx/test/format.py:210
+                report = "Compiled With: %s\n" % compile_cmd
+                report += "Run with environment: %s\n" % env
+                report += libcxx.util.makeReport(cmd, out, err, rc)
----------------
The relevant environment variables should be printed once at the start of the run. IDK why we need to display them again here. I think it only adds noise.

The same goes for the compile command. We should dump all the relevant compile flags at the start of the run during initial configuration.


================
Comment at: libcxx/utils/libcxx/test/format.py:214
                     res = lit.Test.PASS if retry_count == 0 else lit.Test.FLAKYPASS
-                    return res, ''
+                    return lit.Test.Result(res, report)
                 elif rc != 0 and retry_count + 1 == max_retry:
----------------
How is printing the name of the temporary executable file here helpful?


Repository:
  rCXX libc++

https://reviews.llvm.org/D53215