[PATCH] D53127: Fix declaration of _URC_FATAL_PHASE1_ERROR in libc++abi when compiled with gcc (follow-up of D42242)

Steffen Kuhn via Phabricator reviews at reviews.llvm.org
Fri Oct 12 01:23:32 PDT 2018


stefson added a comment.

both of these guards work,  in terms of libc++abi can be compiled with either clang or gcc:

`#if defined(__arm__) && !defined(__clang__)`
`#if defined(__arm__) && defined(__ARM_EABI_UNWINDER__)`

any unforeseen problems with either of them?

(I use llvm-libunwind, and the patch is tested against it)


Repository:
  rCXXA libc++abi

https://reviews.llvm.org/D53127





More information about the libcxx-commits mailing list