[PATCH] D53087: Add benchmarks for std::function.

Samuel Benzaquen via Phabricator reviews at reviews.llvm.org
Wed Oct 10 12:39:24 PDT 2018


sbenza added inline comments.


================
Comment at: benchmarks/function.bench.cpp:210
+int main(int argc, char** argv) {
+  ::benchmark::Initialize(&argc, argv);
+  if (::benchmark::ReportUnrecognizedArguments(argc, argv))
----------------
EricWF wrote:
> I don't love the need to fully qualify the `benchmark` namespace. Perhaps we can do something better?
They don't need to be.
I just copied the main() from the BENCHMARK_MAIN macro, which had them like that.
If you want I can use the macro to define main and move the registration to a global initializer.


Repository:
  rCXX libc++

https://reviews.llvm.org/D53087





More information about the libcxx-commits mailing list