[PATCH] D53049: Annotate scoped_lock as with scoped_lockable attribute

Artem Dergachev via Phabricator reviews at reviews.llvm.org
Wed Oct 10 11:40:52 PDT 2018


NoQ added a comment.

Hmm, this seems to be causing buildbot failures, could you take a look?

Eg., http://lab.llvm.org:8080/green/job/libcxx_master_cmake/5459/consoleFull

  /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/libcxx/thread/thread.mutex/thread_safety_lock_guard.pass.cpp:28:8: error: no member named 'scoped_lock' in namespace 'std'
    std::scoped_lock<std::mutex> lock(m);
    ~~~~~^
  /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/libcxx/thread/thread.mutex/thread_safety_lock_guard.pass.cpp:28:30: error: expected '(' for function-style cast or type construction
    std::scoped_lock<std::mutex> lock(m);
                     ~~~~~~~~~~^
  /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/libcxx/thread/thread.mutex/thread_safety_lock_guard.pass.cpp:28:32: error: no matching function for call to 'lock'
    std::scoped_lock<std::mutex> lock(m);
                                 ^~~~
  /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/include/mutex:372:1: note: candidate function template not viable: requires 2 arguments, but 1 was provided
  lock(_L0& __l0, _L1& __l1)
  ^
  /Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/include/mutex:446:1: note: candidate function template not viable: requires at least 3 arguments, but 1 was provided
  lock(_L0& __l0, _L1& __l1, _L2& __l2, _L3& ...__l3)
  ^
  3 errors generated.
  --
  
  Compilation failed unexpectedly!


Repository:
  rL LLVM

https://reviews.llvm.org/D53049





More information about the libcxx-commits mailing list