[libcxx] r344053 - [libcxx] Mark std::async race condition test as unsupported on Darwin

Louis Dionne ldionne at apple.com
Tue Oct 9 07:57:41 PDT 2018


Author: ldionne
Date: Tue Oct  9 07:57:40 2018
New Revision: 344053

URL: http://llvm.org/viewvc/llvm-project?rev=344053&view=rev
Log:
[libcxx] Mark std::async race condition test as unsupported on Darwin

PR38682 added a test to check for a race condition in std::future.
Part of the fix is part of the dylib, but there is no released version
of mac OS X that ships a dylib containing the fix. Hence, this test can
(and sometimes does) when testing on OS X. This commit marks the test
as unsupported to avoid spurious failures.

Modified:
    libcxx/trunk/test/std/thread/futures/futures.async/async_race.38682.pass.cpp

Modified: libcxx/trunk/test/std/thread/futures/futures.async/async_race.38682.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/thread/futures/futures.async/async_race.38682.pass.cpp?rev=344053&r1=344052&r2=344053&view=diff
==============================================================================
--- libcxx/trunk/test/std/thread/futures/futures.async/async_race.38682.pass.cpp (original)
+++ libcxx/trunk/test/std/thread/futures/futures.async/async_race.38682.pass.cpp Tue Oct  9 07:57:40 2018
@@ -10,6 +10,10 @@
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03
 
+// There's currently no release of OS X whose dylib contains the patch for
+// PR38682. Since the fix for future<void> is in the dylib, this test may fail.
+// UNSUPPORTED: apple-darwin
+
 // This test is designed to cause and allow TSAN to detect a race condition
 // in std::async, as reported in https://bugs.llvm.org/show_bug.cgi?id=38682.
 




More information about the libcxx-commits mailing list