[PATCH] D52405: [libc++] Use exclude_from_explicit_instantiation instead of always_inline

Wed Oct 3 17:20:30 PDT 2018

ldionne added a comment.

In https://reviews.llvm.org/D52405#1254526, @rsmith wrote:

> Makes sense to me. Is there some way you can write a test for this? (Maybe applying `nm` to a linked program?)

What I had in mind is that we should have a build bot that runs the test suite with/without `_LIBCPP_HIDE_FROM_ABI_PER_TU`. If all the current libc++ tests link, this seems to give us the most confidence that nothing is broken. Did you have something more specific in mind that you're concerned about? If so, I'm happy to write a test for it, I'd just like to understand what that is.

Also, are we good to go with https://reviews.llvm.org/D51789, which this patch requires?

Repository:
  rCXX libc++

https://reviews.llvm.org/D52405