[PATCH] D52697: Bug 39129: Speeding up partition_point/lower_bound/upper_bound/ by using unsigned division by 2 when possible.

Denis Yaroshevskiy via Phabricator reviews at reviews.llvm.org
Mon Oct 1 09:28:35 PDT 2018


dyaroshev added inline comments.


================
Comment at: include/algorithm:3213
+            _Integral
+        >::type __size_t_if_safe;
+
----------------
mclow.lists wrote:
> Does `make_unsigned` do what you want here?
I don't think so. Seems like size_t if faster than unsigned: http://quick-bench.com/hATsToKHx8UP3legquGgvT-4qpU
(this is not only this benchmark, I've seen other cases when it happens.


https://reviews.llvm.org/D52697





More information about the libcxx-commits mailing list