[PATCH] D52697: Bug 39129: Speeding up partition_point/lower_bound/upper_bound/ by using unsigned division by 2 when possible.

Marshall Clow via Phabricator reviews at reviews.llvm.org
Mon Oct 1 07:58:40 PDT 2018


mclow.lists added a comment.

In https://reviews.llvm.org/D52697#1250540, @dyaroshev wrote:

> You don't think that it's right to merge this patch? The performance wins are pretty nice. There are plenty of other things for optimizer guys to work on, this is a quite specific case.


I don't think there's a hurry to merge this.
The performance wins are nice - on a micro scale.
Do you have an example in a real app where this makes a difference?

Note: I'm not disparaging the work you've done.
Nor do I think this isn't worth pursuing.
I'm just looking at other approaches.


https://reviews.llvm.org/D52697





More information about the libcxx-commits mailing list