[PATCH] D54966: Implement P1007R3 `std::assume_aligned`
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Wed Nov 28 07:26:33 PST 2018
ldionne marked an inline comment as done.
ldionne added inline comments.
Comment at: test/std/utilities/memory/ptr.align/assume_aligned.pass.cpp:28
+ ASSERT_SAME_TYPE(T*, decltype(std::assume_aligned<1, T>(p)));
+ assert((p == std::assume_aligned<1>(p)));
> ldionne wrote:
> > mclow.lists wrote:
> > > Needs a `LIBCPP_ASSERT_NOEXCEPT(std::assume_aligned<1, T>(p))`
> > This check needs to go into `test/libcxx/<...>`.
> I don't think we need an entire test just for one line.
> We have that macro specifically for libc++-specific assertions.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits