[PATCH] D54804: [libcxx] Remove bad_array_length
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Mon Nov 26 15:08:21 PST 2018
ldionne added a comment.
In D54804#1308795 <https://reviews.llvm.org/D54804#1308795>, @dexonsmith wrote:
> If we have shipped this in libc++abi.dylib, we need to continue supporting it for bincompat of existing apps.
I don't think it's possible for any application to actually use the symbols, as they were marked as unavailable on Darwin. It would technically be possible for an application to depend on the symbol by e.g. forward-declaring it themselves, but I think it is quite unlikely this has ever happened, especially for something that was not even standardized. The same reasoning applies to symbols that we have been exporting "by mistake" through implicit instantiations of function templates that were not marked as hidden. We're comfortable removing such symbols because nobody could depend on those symbols being part of the dylib, except if they _really_ tried hard (by forward declaring the function template and using an explicit instantiation declaration with default visibility).
CHANGES SINCE LAST ACTION
More information about the libcxx-commits