[libcxx] r347471 - [NFC][libcxx] Print human-friendly command line when lit test fails

Louis Dionne ldionne at apple.com
Thu Nov 22 08:10:49 PST 2018


Author: ldionne
Date: Thu Nov 22 08:10:49 2018
New Revision: 347471

URL: http://llvm.org/viewvc/llvm-project?rev=347471&view=rev
Log:
[NFC][libcxx] Print human-friendly command line when lit test fails

We used to print a Python list corresponding to the command. It is more
useful to print the joined string so it can be copy/pasted directly when
a test fails.

Modified:
    libcxx/trunk/utils/libcxx/test/format.py

Modified: libcxx/trunk/utils/libcxx/test/format.py
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/utils/libcxx/test/format.py?rev=347471&r1=347470&r2=347471&view=diff
==============================================================================
--- libcxx/trunk/utils/libcxx/test/format.py (original)
+++ libcxx/trunk/utils/libcxx/test/format.py Thu Nov 22 08:10:49 2018
@@ -206,7 +206,7 @@ class LibcxxTestFormat(object):
                 cmd, out, err, rc = self.executor.run(exec_path, [exec_path],
                                                       local_cwd, data_files,
                                                       env)
-                report = "Compiled With: %s\n" % compile_cmd
+                report = "Compiled With: '%s'\n" % ' '.join(compile_cmd)
                 report += libcxx.util.makeReport(cmd, out, err, rc)
                 if rc == 0:
                     res = lit.Test.PASS if retry_count == 0 else lit.Test.FLAKYPASS




More information about the libcxx-commits mailing list