[libcxx-commits] [libcxx] r347400 - [libcxx] Make sure operator+ is declared with the right visibility attribute

[Eric Fiselier]

This is a configuration we should probably cover with a bot. It's super
easy to omit visibility attributes on the first declaration, only to apply
them to the definition.

On Wed, Nov 21, 2018 at 12:34 PM Louis Dionne via libcxx-commits <
libcxx-commits at lists.llvm.org> wrote:

>
>
>
> ---------- Forwarded message ----------
> From: Louis Dionne <ldionne at apple.com>
> To: libcxx-commits at lists.llvm.org
> Cc:
> Bcc:
> Date: Wed, 21 Nov 2018 17:31:55 -0000
> Subject: [libcxx] r347400 - [libcxx] Make sure operator+ is declared with
> the right visibility attribute
> Author: ldionne
> Date: Wed Nov 21 09:31:55 2018
> New Revision: 347400
>
> URL: http://llvm.org/viewvc/llvm-project?rev=347400&view=rev
> Log:
> [libcxx] Make sure operator+ is declared with the right visibility
> attribute
>
> Otherwise, Clang complains about internal_linkage not being applied to the
> first declaration of the operator (and rightfully so).
>
> Modified:
>     libcxx/trunk/include/string
>
> Modified: libcxx/trunk/include/string
> URL:
> http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/string?rev=347400&r1=347399&r2=347400&view=diff
>
> ==============================================================================
> --- libcxx/trunk/include/string (original)
> +++ libcxx/trunk/include/string Wed Nov 21 09:31:55 2018
> @@ -580,6 +580,7 @@ basic_string<_CharT, _Traits, _Allocator
>  operator+(_CharT __x, const basic_string<_CharT,_Traits,_Allocator>& __y);
>
>  template<class _CharT, class _Traits, class _Allocator>
> +inline _LIBCPP_INLINE_VISIBILITY
>  basic_string<_CharT, _Traits, _Allocator>
>  operator+(const basic_string<_CharT, _Traits, _Allocator>& __x, const
> _CharT* __y);
>
>
>
>
>
>
> ---------- Forwarded message ----------
> From: Louis Dionne via libcxx-commits <libcxx-commits at lists.llvm.org>
> To: libcxx-commits at lists.llvm.org
> Cc:
> Bcc:
> Date: Wed, 21 Nov 2018 09:31:56 -0800 (PST)
> Subject: [libcxx-commits] [libcxx] r347400 - [libcxx] Make sure operator+
> is declared with the right visibility attribute
> _______________________________________________
> libcxx-commits mailing list
> libcxx-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20181121/b23ad22d/attachment.html>