[PATCH] D54810: [libcxx] Apply namespace-scope hidden visibility to libc++

Wed Nov 21 16:27:33 PST 2018

ldionne added a comment.

In https://reviews.llvm.org/D54810#1305831, @EricWF wrote:

> Would it make sense to remove the `-fvisibility-inlines-hidden` from the build at the same time?

Yes, it would.

> Currently doing so causes 37 previously hidden functions to be exported.

Argh. I'll look into that tomorrow. Note that this also checks out with previous experiments I've done where removing hidden visibility attributes on some functions after making the whole namespace hidden result in similar problems.

Repository:
  rCXX libc++

https://reviews.llvm.org/D54810