[PATCH] D54806: [libcxx] Fix incorrect iterator type in vector container test.

Louis Dionne via Phabricator reviews at reviews.llvm.org
Wed Nov 21 12:01:46 PST 2018


ldionne added inline comments.


================
Comment at: test/std/containers/sequences/vector/vector.modifiers/insert_iter_iter_iter.pass.cpp:102
     {
-        std::vector<int, limited_allocator<int, 308> > v(100);
+        typedef std::vector<int, limited_allocator<int, 308>> test_vector_type;
+        test_vector_type v(100);
----------------
ldionne wrote:
> You need spaces between consecutive `>>`'s, otherwise the test won't pass in C++03 mode.
Also, we usually use names like `V` instead of `test_vector_type`, but it doesn't really matter. Just FYI.


https://reviews.llvm.org/D54806





More information about the libcxx-commits mailing list