[PATCH] D54806: [libcxx] Fix incorrect iterator type in vector container test.

Louis Dionne via Phabricator reviews at reviews.llvm.org
Wed Nov 21 12:00:26 PST 2018


ldionne added a comment.

In https://reviews.llvm.org/D54806#1305594, @amakc11 wrote:

> BTW, which tests in the test suite are meant to check for SCARY iterators?


The only ones I could find with a quick grep are:

libcxx/test/std/containers/unord/unord.multimap/scary.pass.cpp
libcxx/test/std/containers/unord/unord.multiset/scary.pass.cpp
libcxx/test/std/containers/associative/multimap/scary.pass.cpp
libcxx/test/std/containers/associative/multiset/scary.pass.cpp

There doesn't seem to be such tests for all containers. However, I don't this SCARY iterators are actually required by the standard (am I wrong?).


https://reviews.llvm.org/D54806





More information about the libcxx-commits mailing list