[PATCH] D54806: [libcxx] Fix incorrect iterator type in vector container test.

Louis Dionne via Phabricator reviews at reviews.llvm.org
Wed Nov 21 11:01:54 PST 2018

ldionne added a comment.

In https://reviews.llvm.org/D54806#1305547, @amakc11 wrote:

> My intention was to be consistent with the `#if TEST_STD_VER >= 11` segment of the test, which does not introduce any `typedef` in the similar context. Should I change both?

Ah, I missed that. Please make the change throughout. Otherwise, one can wonder whether these tests are meant to check for //SCARY// iterators, which they aren't.

  rCXX libc++


More information about the libcxx-commits mailing list