[PATCH] D54772: [libcxx] Reorganize tests since the application of P0602R4

Louis Dionne via Phabricator reviews at reviews.llvm.org
Tue Nov 20 14:24:33 PST 2018

ldionne marked 2 inline comments as done.
ldionne added inline comments.

Comment at: libcxx/test/std/utilities/optional/optional.object/optional.object.assign/copy.pass.cpp:56
         using O = optional<int>;
+#if TEST_STD_VER >= 20
         LIBCPP_STATIC_ASSERT(assign_empty(O{42}), "");
mclow.lists wrote:
> For future proofing, we never explicitly test for unreleased standard versions .
> Instead, we say `TEST_STD_VER > 17`
Ah, sorry, it feels like you've told me before. Eventually I'll remember.

  rCXX libc++


More information about the libcxx-commits mailing list