[PATCH] D54767: [libcxx] Use a type that is always an aggregate in variant's tests

Louis Dionne via Phabricator reviews at reviews.llvm.org
Tue Nov 20 12:06:16 PST 2018

ldionne created this revision.
ldionne added reviewers: EricWF, mclow.lists.
Herald added subscribers: libcxx-commits, arphaman, dexonsmith, jkorous, christof.

In PR39232, we noticed that some variant tests started failing in C++2a mode
with recent Clangs, because the rules for literal types changed in C++2a. As
a result, a temporary fix was checked in (enabling the test only in C++17).

This commit is what I believe should be the long term fix: I removed the
tests that checked constexpr default-constructibility with a weird type
from the tests for index() and valueless_by_exception(), and instead I
added tests for those using an obviously literal type in the test for the
default constructor.

  rCXX libc++



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54767.174819.patch
Type: text/x-patch
Size: 4093 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20181120/ca64a52b/attachment.bin>

More information about the libcxx-commits mailing list