[PATCH] D54677: [hurd] Fix unconditional use of PATH_MAX

Louis Dionne via Phabricator reviews at reviews.llvm.org
Mon Nov 19 16:41:12 PST 2018

ldionne accepted this revision.
ldionne added 1 blocking reviewer(s): EricWF.
ldionne added a comment.

LGTM at a superficial level, I'd like @EricWF to chime in since he's the Filesystem grand master.

Comment at: src/filesystem/operations.cpp:1101
   _LIBCPP_ASSERT(ret > 0, "TODO");
-  buff[ret] = 0;
-  return {buff};
+  buff.get()[ret] = 0;
+  path res = {buff.get()};
You can just use `buf[ret] = '\0'`.

  rCXX libc++


More information about the libcxx-commits mailing list