[PATCH] D54673: Fix some `-Wshadow` diagnostics emitted by Clang trunk

Arthur O'Dwyer via Phabricator reviews at reviews.llvm.org
Mon Nov 19 13:49:18 PST 2018

Quuxplusone added inline comments.

Comment at: include/charconv:549
         __first, __last, __value,
-        [](const char* __p, const char* __last, _Tp& __value,
-           int __base) -> from_chars_result {
+        [](const char* __p, const char* __lastx, _Tp& __valuex,
+           int __basex) -> from_chars_result {
ldionne wrote:
> In this case, would it be less intrusive to rename the parameter from `__first` to `__first_it` or something like that? I think the parameters are used less often here.
That sounds good for `__first` and `__last`, but what about `__value` and `__base`?

  rCXX libc++


More information about the libcxx-commits mailing list