[PATCH] D54339: Fix threads detection on GNU/Hurd

Kamil Rytarowski via Phabricator reviews at reviews.llvm.org
Mon Nov 19 08:02:20 PST 2018

krytarowski added inline comments.

Comment at: include/__config:1146
       defined(__linux__) || \
+      defined(__GNU__) || \
       defined(__APPLE__) || \
ldionne wrote:
> According to https://sourceforge.net/p/predef/wiki/OperatingSystems/, an equivalent way of checking that would be `__gnu_hurd__`. I would prefer that as it is more explicit. Otherwise LGTM.
`__GNU__` is well established constant, used in the wild. I've never seen `__gnu_hurd__` myself, it souds like `__gnu_linux__`...

  rCXX libc++


More information about the libcxx-commits mailing list