[PATCH] D54643: [libcxx] [test] Portability fix: add missing headers to unordered containers tests.
Andrey Maksimov via Phabricator
reviews at reviews.llvm.org
Fri Nov 16 11:35:51 PST 2018
amakc11 created this revision.
amakc11 added a reviewer: EricWF.
Herald added subscribers: libcxx-commits, ldionne.
A bunch of unordered containers tests call library functions, but don't directly include the corresponding header files:
1. fabs() (defined in <cmath> which is not included);
2. is_permutation() (defined in <algorithm> which is not included);
3. next() (defined in <iterator> which is not included).
As a result, these tests won't compile against some conformant libraries.
Please note, that the list of the updated files might be incomplete, since I don't run "post C++11" tests.
Repository:
rCXX libc++
https://reviews.llvm.org/D54643
Files:
test/std/containers/unord/unord.map/unord.map.cnstr/assign_init.pass.cpp
test/std/containers/unord/unord.map/unord.map.cnstr/assign_move.pass.cpp
test/std/containers/unord/unord.map/unord.map.cnstr/init.pass.cpp
test/std/containers/unord/unord.map/unord.map.cnstr/range.pass.cpp
test/std/containers/unord/unord.multimap/unord.multimap.cnstr/assign_copy.pass.cpp
test/std/containers/unord/unord.multimap/unord.multimap.cnstr/assign_init.pass.cpp
test/std/containers/unord/unord.multimap/unord.multimap.cnstr/assign_move.pass.cpp
test/std/containers/unord/unord.multimap/unord.multimap.cnstr/init.pass.cpp
test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range.pass.cpp
test/std/containers/unord/unord.multiset/erase_range.pass.cpp
test/std/containers/unord/unord.multiset/unord.multiset.cnstr/assign_copy.pass.cpp
test/std/containers/unord/unord.multiset/unord.multiset.cnstr/assign_init.pass.cpp
test/std/containers/unord/unord.multiset/unord.multiset.cnstr/assign_move.pass.cpp
test/std/containers/unord/unord.multiset/unord.multiset.cnstr/init.pass.cpp
test/std/containers/unord/unord.multiset/unord.multiset.cnstr/range.pass.cpp
test/std/containers/unord/unord.set/erase_range.pass.cpp
test/std/containers/unord/unord.set/unord.set.cnstr/assign_copy.pass.cpp
test/std/containers/unord/unord.set/unord.set.cnstr/assign_init.pass.cpp
test/std/containers/unord/unord.set/unord.set.cnstr/assign_move.pass.cpp
test/std/containers/unord/unord.set/unord.set.cnstr/init.pass.cpp
test/std/containers/unord/unord.set/unord.set.cnstr/range.pass.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54643.174413.patch
Type: text/x-patch
Size: 9518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20181116/678ac9d8/attachment-0001.bin>
More information about the libcxx-commits
mailing list