[PATCH] D54479: Mark some library types and templates with visibility+availability attributes.

[Arthur O'Dwyer via Phabricator]

Quuxplusone created this revision.
Quuxplusone added a reviewer: ldionne.
Herald added a subscriber: libcxx-commits.

I asked: "Why aren't these class types and templates marked with the seemingly appropriate attributes? Should they be?"
@EricWF said: "Add @ldionne to the review. Apple is the one who cares about availability."


Repository:
  rCXX libc++

https://reviews.llvm.org/D54479

Files:
  include/future
  include/shared_mutex


Index: include/shared_mutex
===================================================================
--- include/shared_mutex
+++ include/shared_mutex
@@ -307,7 +307,7 @@
 }
 
 template <class _Mutex>
-class shared_lock
+class _LIBCPP_TEMPLATE_VIS shared_lock
 {
 public:
     typedef _Mutex mutex_type;
Index: include/future
===================================================================
--- include/future
+++ include/future
@@ -528,7 +528,7 @@
 #endif
 }
 
-class _LIBCPP_TYPE_VIS _LIBCPP_AVAILABILITY_FUTURE __assoc_sub_state
+class _LIBCPP_AVAILABILITY_FUTURE __assoc_sub_state
     : public __shared_count
 {
 protected:
@@ -2298,7 +2298,7 @@
 }
 
 template <class _Fp, class... _Args>
-class __async_func
+class _LIBCPP_AVAILABILITY_FUTURE __async_func
 {
     tuple<_Fp, _Args...> __f_;
 
@@ -2369,7 +2369,7 @@
 // shared_future
 
 template <class _Rp>
-class _LIBCPP_TEMPLATE_VIS shared_future
+class _LIBCPP_TEMPLATE_VIS _LIBCPP_AVAILABILITY_FUTURE shared_future
 {
     __assoc_state<_Rp>* __state_;
 
@@ -2443,7 +2443,7 @@
 }
 
 template <class _Rp>
-class _LIBCPP_TEMPLATE_VIS shared_future<_Rp&>
+class _LIBCPP_TEMPLATE_VIS _LIBCPP_AVAILABILITY_FUTURE shared_future<_Rp&>
 {
     __assoc_state<_Rp&>* __state_;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54479.173866.patch
Type: text/x-patch
Size: 1227 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20181113/c3c45d21/attachment.bin>