[PATCH] D53994: Fixing lower bound regression in certain situations.
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Tue Nov 13 08:30:22 PST 2018
ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.
================
Comment at: half_positive.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
This should not be at the top-level of the repository. It should be in `test/libcxx/somewhere`
================
Comment at: half_positive.pass.cpp:12
+
+// template <typename _Tp> _Tp __half_positive(const _Tp&);
+
----------------
Please remove this line -- it makes it look as though this is a standard-provided algorithm.
https://reviews.llvm.org/D53994
More information about the libcxx-commits
mailing list