[PATCH] D54338: Fix threads build on GNU/Hurd

Louis Dionne via Phabricator reviews at reviews.llvm.org
Sun Nov 11 19:12:38 PST 2018

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I’m OK with the change but please don’t repeat the condition on L24.

Re-upload and I will commit.

Comment at: src/thread.cpp:24
 #   include <sys/sysctl.h>
-# endif // defined(BSD)
+# endif // defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__DragonFly__) || defined(__APPLE__)
 #endif // defined(__unix__) || (defined(__APPLE__) && defined(__MACH__))
I really don’t feel like it is useful to repeat the condition given the #if spans only one line.

  rCXX libc++


More information about the libcxx-commits mailing list