[PATCH] D55963: [pstl] Initial integration with LLVM's CMake
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Thu Dec 20 15:32:41 PST 2018
ldionne added a subscriber: MikeDvorskiy.
ldionne marked an inline comment as done.
ldionne added inline comments.
================
Comment at: pstl/cmake/FindTBB.cmake:12
-# Firstly search for TBB in config mode (i.e. search for TBBConfig.cmake).
-find_package(TBB QUIET CONFIG)
----------------
This is required because otherwise they look for both the release and the Debug version of TBB, and we don't find anything if both are not provided. The rest of `FindTBB.cmake` handles this properly, so I'm not sure why they even try to defer to the `TBBConfig.cmake`.
Repository:
rPSTL pstl
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55963/new/
https://reviews.llvm.org/D55963
More information about the libcxx-commits
mailing list