[PATCH] D55942: [CMake] Add libunwind when 'all' is being passed as LLVM_ENABLE_PROJECTS

Louis Dionne ldionne at apple.com
Thu Dec 20 10:39:45 PST 2018


Thanks!

Louis

> On Dec 20, 2018, at 13:38, Zachary Turner <zturner at google.com> wrote:
> 
> It’s fine, i can review some CMake stuff since I’ve messed with it a fair amount.
> 
> Anyway, change looks straightforward enough, lgtm (I don’t have access to phab right now so I can’t officially stamp it from phab)
> On Thu, Dec 20, 2018 at 10:16 AM Louis Dionne via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> ldionne added a comment.
> 
> @zturner Sorry if you're the wrong person to look at this, but you're on the reviewer list for the last change to this line. I'll find someone else if you're the wrong person.
> 
> 
> Repository:
>   rL LLVM
> 
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D55942/new/ <https://reviews.llvm.org/D55942/new/>
> 
> https://reviews.llvm.org/D55942 <https://reviews.llvm.org/D55942>
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20181220/959b4a0d/attachment.html>


More information about the libcxx-commits mailing list