[PATCH] D55920: A fix of __pstl namespace usage.

Thomas Rodgers via Phabricator reviews at reviews.llvm.org
Thu Dec 20 10:28:18 PST 2018


rodgert added a comment.

In D55920#1337803 <https://reviews.llvm.org/D55920#1337803>, @ldionne wrote:

> LGTM, but `internal` should be `__internal` too.


jwakely and I discussed this, and ideally yes it probably *should* be __internal, but std::internal is a reserved name so we needn't be concerned about accidental macro substitution for it.


Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55920/new/

https://reviews.llvm.org/D55920





More information about the libcxx-commits mailing list