[PATCH] D55889: The initial commit of the Parallel STL upstream

[Mikhail Dvorskiy via Phabricator]

MikeDvorskiy marked 3 inline comments as done.
MikeDvorskiy added inline comments.


================
Comment at: .clang-format:10
+AlwaysBreakTemplateDeclarations: true
+AlwaysBreakAfterReturnType: All
+PointerAlignment: Left
----------------
ldionne wrote:
> Ew.
What do you mean?


================
Comment at: .clang-format:13
+AllowShortIfStatementsOnASingleLine: false
+BreakBeforeBraces: Allman
+
----------------
ldionne wrote:
> Shouldn't we follow LLVM here?
As far as Parallel STL  is going to be a part of libcxx library, I've chosen the values  of the options to have consistent style with the real format style of "libcxx" source code, for example  see libcxx/include/algorithm file (https://github.com/llvm-mirror/libcxx/blob/master/include/algorithm).


================
Comment at: .clang-format:15
+
+# Disable formatting options which may break tests.
+SortIncludes: false
----------------
ldionne wrote:
> What tests break?
Actually, it was taken from LLVM,  libcxx/.clang-format 
And I agree with it, at least with "SortIncludes: false" due to it can break compilation of the tests (and another user's code). For example the test include first a test configuration file which defines several macros..



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55889/new/

https://reviews.llvm.org/D55889