[PATCH] D55889: The initial commit of the Parallel STL upstream
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Wed Dec 19 09:49:15 PST 2018
ldionne added a comment.
Minor questions about formatting, but as they say, don't look a gift horse in the mouth.
I'm fine with this, we can change whatever we need to change after this is committed. Thanks!
================
Comment at: .clang-format:10
+AlwaysBreakTemplateDeclarations: true
+AlwaysBreakAfterReturnType: All
+PointerAlignment: Left
----------------
Ew.
================
Comment at: .clang-format:13
+AllowShortIfStatementsOnASingleLine: false
+BreakBeforeBraces: Allman
+
----------------
Shouldn't we follow LLVM here?
================
Comment at: .clang-format:15
+
+# Disable formatting options which may break tests.
+SortIncludes: false
----------------
What tests break?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55889/new/
https://reviews.llvm.org/D55889
More information about the libcxx-commits
mailing list