[libcxx] r349378 - [test] [re.traits] Remove asserts failing due to invalid UTF-8

Michal Gorny mgorny at gentoo.org
Mon Dec 17 11:13:41 PST 2018


Author: mgorny
Date: Mon Dec 17 11:13:41 2018
New Revision: 349378

URL: http://llvm.org/viewvc/llvm-project?rev=349378&view=rev
Log:
[test] [re.traits] Remove asserts failing due to invalid UTF-8

Remove the two test cases for \xDA and \xFA with UTF-8 locale, as both
characters alone are invalid in UTF-8 (short sequences).  Upon removing
them, the test passes on Linux again (and also on NetBSD, after adding
appropriate locale configuration).

Differential Revision: https://reviews.llvm.org/D55746

Modified:
    libcxx/trunk/test/std/re/re.traits/translate_nocase.pass.cpp

Modified: libcxx/trunk/test/std/re/re.traits/translate_nocase.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.traits/translate_nocase.pass.cpp?rev=349378&r1=349377&r2=349378&view=diff
==============================================================================
--- libcxx/trunk/test/std/re/re.traits/translate_nocase.pass.cpp (original)
+++ libcxx/trunk/test/std/re/re.traits/translate_nocase.pass.cpp Mon Dec 17 11:13:41 2018
@@ -19,9 +19,6 @@
 // XFAIL: with_system_cxx_lib=macosx10.7
 // XFAIL: with_system_cxx_lib=macosx10.8
 
-// TODO: investigation needed
-// XFAIL: linux-gnu
-
 #include <regex>
 #include <cassert>
 
@@ -47,8 +44,6 @@ int main()
         assert(t.translate_nocase('.') == '.');
         assert(t.translate_nocase('a') == 'a');
         assert(t.translate_nocase('1') == '1');
-        assert(t.translate_nocase('\xDA') == '\xFA');
-        assert(t.translate_nocase('\xFA') == '\xFA');
     }
     {
         std::regex_traits<wchar_t> t;




More information about the libcxx-commits mailing list