[PATCH] D55746: [libcxx] [test] [re.traits] Remove asserts failing due to invalid UTF-8

Marshall Clow via Phabricator reviews at reviews.llvm.org
Mon Dec 17 07:05:39 PST 2018


mclow.lists added a comment.

Just to be clear - I'm quite willing to believe that the tests are wrong, and should be changed.  But `std::char_traits<char>().translate_nocase('\xFA')` has some behavior. Should it return 0? 1? '\xFA`? throw an exception? Cause the computer to catch fire? ;-)


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55746/new/

https://reviews.llvm.org/D55746





More information about the libcxx-commits mailing list