[PATCH] D55763: [Sparc] Add Sparc V8 support

[Marshall Clow via Phabricator]

mclow.lists added a comment.

In general, this looks reasonable. No being a sparc expert, I don't know if it's correct, but it fits in with the existing libunwind structure.



================
Comment at: src/DwarfParser.hpp:687
 #endif
+    case DW_CFA_GNU_window_save:
+      for (reg = UNW_SPARC_O0; reg <= UNW_SPARC_O7; reg++) {
----------------
Should this be wrapped in `#ifdef _LIBUNWIND_TARGET_SPARC ` ?


Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55763/new/

https://reviews.llvm.org/D55763