[PATCH] D55674: [libunwind] [SEH] Add initial support for AArch64

Charles Davis via Phabricator reviews at reviews.llvm.org
Thu Dec 13 15:29:08 PST 2018


cdavis5x added a comment.

LGTM, but I'd feel better if someone else signed off on this, too.



================
Comment at: src/Unwind-seh.cpp:175-176
     exc->private_[2] = disp->TargetPc;
     unw_get_reg(&cursor, UNW_ARM_R0, &retval);
     unw_get_reg(&cursor, UNW_ARM_R1, &exc->private_[3]);
 #endif
----------------
This looks suspicious for AArch64... I guess the values for `UNW_ARM_R0` and `UNW_ARM64_X0` are the same.


Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55674/new/

https://reviews.llvm.org/D55674





More information about the libcxx-commits mailing list