[PATCH] D55404: [libcxx] Support building static library with hidden visibility

Mon Dec 10 19:11:25 PST 2018

phosek added a comment.

In D55404#1325906 <https://reviews.llvm.org/D55404#1325906>, @ldionne wrote:

> I was going to say "why didn't you just fix `-fvisibility=hidden` to do the right thing for `new` and `delete`"? But then I read the discussion in https://reviews.llvm.org/D53787. However, after reading that, I'm strongly questioning whether you actually want `new` and `delete` to have hidden visibility. And if you actually do, it seems to me like the arguments in https://reviews.llvm.org/D53787 are somewhat defeated, no?

I'm not sure what you mean, can you elaborate on the last sentence? Without `-fvisibility-global-new-delete-hidden` we would end up with `new` and `delete` symbols being exported from the shared library.

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55404/new/

https://reviews.llvm.org/D55404