[PATCH] D55517: Remove `_VSTD`

Marshall Clow via Phabricator reviews at reviews.llvm.org
Mon Dec 10 10:51:17 PST 2018


mclow.lists added a comment.

In D55517#1325829 <https://reviews.llvm.org/D55517#1325829>, @ldionne wrote:

> I personally like this change but I'd wait a bit to see whether other people oppose (and why) before submitting.


I do not like this change.
I think that the loss of flexibility may come back to bite is in the future.

However, my main objection is that `_VSTD` is a noticeable chuck of all caps in the source code; it's an indication that we're deliberately qualifying something to disable ADL.
`std` is much less "in your face" - i.e, easier to miss.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55517/new/

https://reviews.llvm.org/D55517





More information about the libcxx-commits mailing list