[PATCH] D55427: [libcxx] Use specialized helper for __bit_reference count
Marshall Clow via Phabricator
reviews at reviews.llvm.org
Fri Dec 7 12:28:30 PST 2018
mclow.lists added a comment.
In D55427#1323656 <https://reviews.llvm.org/D55427#1323656>, @mclow.lists wrote:
> This looks like a behavior change to me.
> The old code calls `__count_bool_true` if the `_Tp` can be `static_cast` to `bool`, and `__count_bool_false` otherwise.
> The new code calls `__count_bool_true` if the `_Tp` is exactly `bool`, and `__count_bool_false` otherwise.
Sorry; the old code calls `__count_bool_true` if the `static_cast<bool>(value)` is true, and `__count_bool_false` otherwise.
Repository:
rCXX libc++
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55427/new/
https://reviews.llvm.org/D55427
More information about the libcxx-commits
mailing list