[PATCH] D55308: Implement the second part of P0482 (char8_t)

[Marshall Clow via Phabricator]

mclow.lists marked 3 inline comments as done.
mclow.lists added inline comments.


================
Comment at: test/std/strings/basic.string/string.cons/string_view_size_size_deduction.pass.cpp:79
     }
+#if defined(__cpp_lib_char8_t) && __cpp_lib_char8_t >= 201811L
     {
----------------
Oops. This was supposed to be an addition, not a replacement


================
Comment at: test/std/strings/string.view/string_view.literals/literal.pass.cpp:21
 
+//	This is changed by P0482 to return a std::u8string - re-enable when we implement that.
+#if defined(__cpp_lib_char8_t) && __cpp_lib_char8_t >= 201811L
----------------
Remove this comment.


================
Comment at: test/std/strings/string.view/string_view.literals/literal.pass.cpp:40
     std::wstring_view Lfoo;
+	u8string_view u8foo;
     std::u16string_view ufoo;
----------------
Tab


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55308/new/

https://reviews.llvm.org/D55308