[Libclc-dev] [PATCH 1/2] Add cmake build system

[Jan Vesely via Libclc-dev]

On Fri, 2018-11-16 at 21:59 -0600, Aaron Watry via Libclc-dev wrote:
> On Tue, Nov 13, 2018 at 2:18 PM Jan Vesely via Libclc-dev
> [SNIP]
> In time? Or sooner rather than later?

I plan to redo this after the old build system is gone. Otherwise it'd
need changes in two places.
My idea is to use add $target/include (like "r600/include") to inc
paths and move .inc files there.
It'd also help with handling datalyaouts in .ll files. we could just
to "#include "datalayout.inc".

> > 
> [SNIP}

> Looks fairly reasonable to me.  I tested it out on my RX580 with a
> sampling of the CTS and things looked ok.
> 
> Couple minor spelling errors noted above, and just pointing out your
> FIXME, but from a non-CMake-expert's viewpoint it looks ok.
> 
> You can definitely have a whole-hearted tested/acked-by from me. You
> could put a reviewed-by from me on as well, but knowing that I
> might've missed some subtle pieces of how CMake works.

thanks a lot for all the reviews. I fixed the typos locally.
cmake depends on the other cleanup series to get rid of OVERRIDE files
(since they are not supported).
So I'll hold these until then.

thanks a lot again,
Jan

> 
> --Aaron
> 
> --Aaron
> 
> 
> > 
> > _______________________________________________
> > Libclc-dev mailing list
> > Libclc-dev at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev
> 
> _______________________________________________
> Libclc-dev mailing list
> Libclc-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/libclc-dev/attachments/20181118/92319f0d/attachment.sig>