[Libclc-dev] [PATCH 1/1] clc_sqrt: Reuse unary_decl.inc

[Aaron Watry via Libclc-dev]

LGTM.

Reviewed-by: Aaron Watry <awatry at gmail.com>
Tested-by: Aaron Watry <awatry at gmail.com>

--Aaron

On Tue, 2018-05-01 at 16:47 -0400, Jan Vesely via Libclc-dev wrote:
> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> ---
>  generic/include/math/clc_sqrt.h   | 30 +++------------------------
> ---
>  generic/include/math/clc_sqrt.inc | 23 -----------------------
>  2 files changed, 3 insertions(+), 50 deletions(-)
>  delete mode 100644 generic/include/math/clc_sqrt.inc
> 
> diff --git a/generic/include/math/clc_sqrt.h
> b/generic/include/math/clc_sqrt.h
> index 8fbf9eb..60e183f 100644
> --- a/generic/include/math/clc_sqrt.h
> +++ b/generic/include/math/clc_sqrt.h
> @@ -1,29 +1,5 @@
> -/*
> - * Copyright (c) 2015 Advanced Micro Devices, Inc.
> - *
> - * Permission is hereby granted, free of charge, to any person
> obtaining a copy
> - * of this software and associated documentation files (the
> "Software"), to deal
> - * in the Software without restriction, including without limitation
> the rights
> - * to use, copy, modify, merge, publish, distribute, sublicense,
> and/or sell
> - * copies of the Software, and to permit persons to whom the
> Software is
> - * furnished to do so, subject to the following conditions:
> - *
> - * The above copyright notice and this permission notice shall be
> included in
> - * all copies or substantial portions of the Software.
> - *
> - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
> - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING FROM,
> - * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> DEALINGS IN
> - * THE SOFTWARE.
> - */
> -
> -#ifdef cl_khr_fp64
> -#pragma OPENCL EXTENSION cl_khr_fp64 : enable
> -#endif
> -
> -#define __CLC_BODY <math/clc_sqrt.inc>
> +#define __CLC_FUNCTION __clc_sqrt
> +#define __CLC_BODY <clc/math/unary_decl.inc>
>  #include <clc/math/gentype.inc>
>  #undef __CLC_BODY
> +#undef __CLC_FUNCTION
> diff --git a/generic/include/math/clc_sqrt.inc
> b/generic/include/math/clc_sqrt.inc
> deleted file mode 100644
> index d27243c..0000000
> --- a/generic/include/math/clc_sqrt.inc
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -/*
> - * Copyright (c) 2015 Advanced Micro Devices, Inc.
> - *
> - * Permission is hereby granted, free of charge, to any person
> obtaining a copy
> - * of this software and associated documentation files (the
> "Software"), to deal
> - * in the Software without restriction, including without limitation
> the rights
> - * to use, copy, modify, merge, publish, distribute, sublicense,
> and/or sell
> - * copies of the Software, and to permit persons to whom the
> Software is
> - * furnished to do so, subject to the following conditions:
> - *
> - * The above copyright notice and this permission notice shall be
> included in
> - * all copies or substantial portions of the Software.
> - *
> - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
> - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING FROM,
> - * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> DEALINGS IN
> - * THE SOFTWARE.
> - */
> -
> -_CLC_OVERLOAD _CLC_DECL __CLC_GENTYPE __clc_sqrt(__CLC_GENTYPE a);